Skip to content

feat(cli): add --secrets-file flag for lifecycle command env injection#179

Merged
skevetter merged 4 commits into
mainfrom
d226/secrets-file
May 3, 2026
Merged

feat(cli): add --secrets-file flag for lifecycle command env injection#179
skevetter merged 4 commits into
mainfrom
d226/secrets-file

Conversation

@skevetter

@skevetter skevetter commented May 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds --secrets-file flag to the up command accepting a dotenv-style file path
  • Parses KEY=VALUE pairs and injects them as environment variables into lifecycle commands (onCreateCommand, postCreateCommand, etc.)
  • Secrets do not override existing env vars (config takes precedence)
  • New pkg/secrets package with ParseSecretsFile function and comprehensive unit tests

@coderabbitai

coderabbitai Bot commented May 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 29 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af5a72a8-7d98-43b3-8ba3-770b2c9c86c5

📥 Commits

Reviewing files that changed from the base of the PR and between 77d40f5 and 0c65b7a.

📒 Files selected for processing (12)
  • cmd/agent/container/deferred_hooks.go
  • cmd/agent/container/post_attach.go
  • cmd/agent/container/setup.go
  • cmd/up.go
  • e2e/tests/up/provider_docker.go
  • e2e/tests/up/testdata/docker-secrets-file/.devcontainer.json
  • pkg/devcontainer/setup/lifecyclehooks.go
  • pkg/devcontainer/setup/lifecyclehooks_test.go
  • pkg/devcontainer/setup/setup.go
  • pkg/provider/workspace.go
  • pkg/secrets/secrets.go
  • pkg/secrets/secrets_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 14 minutes and 29 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify

netlify Bot commented May 3, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 0c65b7a
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f76762afa0ab0008e6b165

@github-actions github-actions Bot added the size/l label May 3, 2026
@skevetter
skevetter marked this pull request as ready for review May 3, 2026 14:33
@skevetter
skevetter enabled auto-merge (squash) May 3, 2026 14:33
@skevetter
skevetter merged commit 8a996c3 into main May 3, 2026
90 of 92 checks passed
@skevetter
skevetter deleted the d226/secrets-file branch May 3, 2026 16:18
This was referenced May 16, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/l

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skevetter